Skip to content

Fix CI for Swift 5.3 #408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 19, 2021
Merged

Fix CI for Swift 5.3 #408

merged 1 commit into from
Aug 19, 2021

Conversation

fabianfett
Copy link
Member

@fabianfett fabianfett commented Aug 19, 2021 •
edited
Loading

Motivation

The Swift 5.3 CI currently fails with the error:

ERROR:  Error installing jazzy:
	The last version of jazzy (>= 0) to support your Ruby & RubyGems was 0.13.7. Try installing it with `gem install jazzy -v 0.13.7`
	jazzy requires Ruby version >= 2.6.3. The current ruby version is 2.5.0.

Example log: https://ci.swiftserver.group/job/async-http-client-swift53-prb/338/console

Changes

  • Explicitly set jazzy version number

Result

Happy Swift 5.3 CI

@fabianfett fabianfett requested review from tomerd and glbrntt August 19, 2021 15:20
glbrntt
glbrntt reviewed Aug 19, 2021
View reviewed changes
Copy link
Collaborator

@glbrntt glbrntt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does AHC actually build + publish docs?

@fabianfett
Copy link
Member Author

fabianfett commented Aug 19, 2021 •
edited
Loading

last version is 1.2.3...

https://swift-server.github.io/async-http-client/docs/current/AsyncHTTPClient/index.html

@glbrntt
Copy link
Collaborator

glbrntt commented Aug 19, 2021

last version is 1.2.3...

https://swift-server.github.io/async-http-client/docs/current/AsyncHTTPClient/index.html

Ah, cool, I didn't realise we published them at some point. I guess @tomerd will have some insight on why the last version is 1.2.3.

glbrntt
glbrntt approved these changes Aug 19, 2021
View reviewed changes
Copy link
Collaborator

@glbrntt glbrntt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine for now but maybe the ruby version should be updated and the jazzy version unpinned.

@fabianfett fabianfett added the semver/none No version bump required. label Aug 19, 2021
@fabianfett fabianfett merged commit e696112 into swift-server:main Aug 19, 2021
@fabianfett fabianfett deleted the ff-fix-ci-for-5.3 branch August 19, 2021 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glbrntt glbrntt glbrntt approved these changes

@tomerd tomerd Awaiting requested review from tomerd

Assignees
No one assigned
Labels
semver/none No version bump required.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fabianfett @glbrntt